Conversation
filiphr
force-pushed
the
jackson-3
branch
2 times, most recently
from
37fd35f to
253dbed
Compare
Use Jackson 3 instead of Jackson 2 in our entire codebase Using JsonMapper builder and JsonMapper.shared() in appropriate places Use Jackson 3 with Spring Web
* Jackson 3 textValue() fails if node is not string or null * Treat RecordKey JsonCreator as delegating (this is also applicable to Jackson 2) * Fix incorrect expected JSON
…actCandidates for parsing recipients
The Flowable REST Application contains both Jackson 2 and Jackson 3. However, the flowable engines have an optional dependency on Jackson 2. If Jackson 2 is needed it should be manually configured. All previous places that were using Jackson 2 for variable values. e.g. Task Candidates etc. are now supporting both Jackson 2 and Jackson 3 values. Storing Jackson 3 and Jackson 2 ObjectNode / ArrayNode variables is supported regardless of the preferred variable json mapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for adding support and upgrading to Jackson 3.
It is consisted of multiple commits in order to make the review easier:
com.fasterxml.jackson.databindandcom.fasterxml.jackson.coretotools.jackson.databindandtools.jackson.coreISO8601DateFormatin testsBaseMailActivityDelegateto engine common andCandidateUtil#extractCandidatesfor parsing recipients - Makes it easier to reuse things from flowable-engine-commoncom.fasterxml.jackson.databindby mistake